Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Conversion of the ComboBox #6354

Merged
merged 36 commits into from
May 24, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented Apr 24, 2024

No description provided.

@anicyne anicyne linked an issue Apr 24, 2024 that may be closed by this pull request
@anicyne anicyne requested a review from sdvg April 25, 2024 06:27
packages/schema/src/components/combo-box.ts Outdated Show resolved Hide resolved
packages/schema/src/components/combo-box.ts Outdated Show resolved Hide resolved
packages/schema/src/components/combo-box.ts Outdated Show resolved Hide resolved
packages/samples/react/src/components/combobox/routes.ts Outdated Show resolved Hide resolved
packages/samples/react/src/components/combobox/basic.tsx Outdated Show resolved Hide resolved
packages/components/src/components/combobox/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/combobox/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/combobox/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/combobox/component.tsx Outdated Show resolved Hide resolved
packages/components/src/components/combobox/component.tsx Outdated Show resolved Hide resolved
@anicyne anicyne requested a review from sdvg April 30, 2024 07:38
@sdvg
Copy link
Member

sdvg commented Apr 30, 2024

Wenn ich in das Eingabefeld klicke, kann ich die aktuelle Eingabe nicht erweitern. Ich muss erst Zeichen löschen, um frei schreiben zu können.

@sdvg
Copy link
Member

sdvg commented Apr 30, 2024

Auch wenn ich z.B. in das leere Eingabefeld klicke, würde ich erwarten, Text eingeben zu können. Sattdessen sehe ich nicht, was ich getippt habe und nur die Auswahl in den Vorschlägen ändert sich.

Beispiel:
image

Ich habe hier bereits die Buchstaben Fr eingegeben. Ich würde erwarten, dass diese im Eingabefeld sichtbar sind, und nur noch der Vorschlag "Frau" erscheint, weil die anderen rausgefiltert wurden.

@sdvg
Copy link
Member

sdvg commented Apr 30, 2024

Sobald ich eine Eingabe erzeugt habe, die nicht in den Vorschläge vorhanden ist, kann ich die Vorschlagsliste nicht mehr mit Klick öffnen.
image

(Spec: "Bei Öffnen der Vorschlagsliste (ungeachtet eines eingegebenen Wertes) wird die Liste ungefiltert dargestellt.
")

@chrisalat chrisalat self-requested a review May 2, 2024 07:51
Copy link
Contributor

github-actions bot commented May 6, 2024

@anicyne anicyne requested a review from chrisalat May 6, 2024 09:11
Copy link
Contributor

@chrisalat chrisalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insgesamt sieht es jetzt gut aus 👍
Das letzte wäre vielleicht noch die styles entsprechend @sdvg anzupassen und noch das dropdown _label in die Übersetzungen auszulagern.

@anicyne anicyne self-assigned this May 21, 2024
@anicyne anicyne requested a review from deleonio May 21, 2024 07:15
@anicyne anicyne requested a review from sdvg May 21, 2024 08:29
@anicyne anicyne requested a review from sdvg May 21, 2024 10:17
@anicyne anicyne requested a review from sdvg May 22, 2024 08:27
sdvg
sdvg previously approved these changes May 22, 2024
@deleonio deleonio removed the request for review from chrisalat May 24, 2024 07:23
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
deleonio
deleonio previously approved these changes May 24, 2024
Signed-off-by: Martin <6279703+deleonio@users.noreply.github.com>
@deleonio deleonio merged commit a04866c into develop May 24, 2024
3 of 4 checks passed
@deleonio deleonio deleted the 5846-feature-comboBox-implementation branch May 24, 2024 07:40
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

🛹 Component: Umsetzung der ComboBox
5 participants