Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes appointment form handling #6393

Merged
merged 3 commits into from
May 16, 2024
Merged

Bugfixes appointment form handling #6393

merged 3 commits into from
May 16, 2024

Conversation

chrisalat
Copy link
Member

@chrisalat chrisalat commented May 2, 2024 •
edited by deleonio

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully (by reviewer) or not relevant

@chrisalat
Removed disable button attribute, fixed appointment time radios, fixe…
04223c3 
…d focus on error list and refactored some methods

Refs: #6183
@chrisalat chrisalat linked an issue May 2, 2024 that may be closed by this pull request
🛠️ Todo: Formular-Handling Demo bei Terminauswahl verbessern #6183
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2024 •
edited

Netlify Draft Deployment
URL: https://6644882652099b8c87d02250--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/6644882652099b8c87d02250

@chrisalat
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

deleonio
deleonio requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte mal prüfen und ggf. das abweichende Verhalten dokumentieren.

packages/samples/react/src/scenarios/appointment-form/PersonalInformationForm.tsx Show resolved Hide resolved
@deleonio deleonio force-pushed the develop branch 2 times, most recently from 487bb0f to f56f225 Compare May 14, 2024 02:40
deleonio
deleonio requested changes May 14, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retest: Einige valide Termine wieder auswählbar machen (aktuell alle nicht wählbar)

Ich habe auf dem Test-Link mal nachgetestet und ich konnte leider keine Zeit auswählen. Ansonsten hat es gut funktioniert.

@chrisalat chrisalat requested a review from deleonio May 15, 2024 21:27
@deleonio deleonio merged commit b5271c9 into develop May 16, 2024
5 checks passed
@deleonio deleonio deleted the 6183-formula-handling-sample-bugfix-v2 branch May 16, 2024 04:25
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deleonio deleonio deleonio approved these changes

Assignees

@chrisalat chrisalat

Labels
re-review v2
Projects
KoliBri Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🛠️ Todo: Formular-Handling Demo bei Terminauswahl verbessern
2 participants
@chrisalat @deleonio