Adjust input field behavior to keep placeholder text visible #6406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Netlify Draft Deployment |
laske185
requested changes
May 8, 2024
| @@ -130,6 +137,8 @@ export class KolInputText implements API { | |||
| value={this.state._value as string} | |||
| {...this.controller.onFacade} | |||
| onChange={this.onChange} | |||
| onFocus={console.log} | |||
| @@ -40,6 +40,9 @@ export class KolInputText implements API { | |||
| private ref?: HTMLInputElement; | |||
| private oldValue?: string; | |||
|
|
|||
| @State() | |||
| private showPlaceholder = true; | |||
There was a problem hiding this comment.
showPlaceholder wird nie false
deleonio
requested changes
May 14, 2024
There was a problem hiding this comment.
Könnt Ihr mal schauen, ob das "einfacher" ohne State und Methode umgesetzt werden kann?
Einfach:
maxlength={this.state._maxLength}
name={this.state._name}
pattern={this.state._pattern}
placeholder={this.ref?.value === '' || this.ref?.value === undefined ? this.state._placeholder : undefined}
readOnly={this.state._readOnly}
required={this.state._required}
size={this.state._size}| (event.target as HTMLInputElement).value === '' ? (this.showPlaceholder = true) : (this.showPlaceholder = false); | ||
| }; | ||
|
|
||
| private readonly SetShowPlaceholder = () => { |
There was a problem hiding this comment.
Kleine Korrektur: Methoden-Namen beginnen immer mit einem kleinen Buchstaben.
sdvg
changed the title
/**
* Beim Screenreader NVDA wird der Placeholder mit
* vorgelesen. Somit kann es vorkommen, dass das
* Label und der Placeholder vorgelesen werden.
*
* Aufgrund dessen, dass das Label immer vorgelesen
* werden muss, kann das zusätzliche Vorlesen des
* Placeholders störend sein.
*
* Damit beim Fokussieren das "doppelte" vorlesen
* vermieden werden kann, wird der Placeholder für
* den fokussierten Feldstatus entfernt.
*
* Hinweis: Für alle Nutzenden müssen alle darge-
* stellten Inhalte, also auch der Place-
* holder, gleichermaßen zugänglich sein.
* Das oben beschriebene Handling erfüllt
* diese Anforderung nicht.
*/ |
|
Auf Barrierefreiheit getestet. Es wurde kein Fehler hinsichtlich Barrierefreiheit gefunden |
deleonio
reviewed
May 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Definition of Done checklist