Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing keyboard shortcuts for tree navigation #6415

Merged
merged 5 commits into from
May 30, 2024
Merged

Implement missing keyboard shortcuts for tree navigation #6415

merged 5 commits into from
May 30, 2024

Conversation

anicyne
Copy link
Contributor

@anicyne anicyne commented May 13, 2024 •
edited by laske185

Refs: #6160

☑️ Definition of Done checklist

  • Meaningful title for the release notes
  • Pull request is linked to a problem
  • All changes relate to the problem
  • A11y tests performed successfully or not relevant
  • Manual test performed successfully (by reviewer) or not relevant

@anicyne anicyne self-assigned this May 13, 2024
@anicyne anicyne linked an issue May 13, 2024 that may be closed by this pull request
Tree - Keyboard-Shortcuts #6160
Closed
5 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

Netlify Draft Deployment
URL: https://66583045be0c9ec3c13b8393--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/66583045be0c9ec3c13b8393

@deleonio deleonio force-pushed the develop branch 2 times, most recently from 487bb0f to f56f225 Compare May 14, 2024 02:40
sdvg
sdvg previously approved these changes May 15, 2024
View reviewed changes
@deleonio
Copy link
Contributor

@AntnSaj bitte testen

@fohi17
Copy link

fohi17 commented May 27, 2024

@deleonio Ich gehe davon aus, dass es hier nur um die shortcuts ging und lasse daher Screenreader außen vor.
Es ist zwar nicht unbedingt ein BF-Tema, aber wenn man auf einem Unterpunkt Pfeil-Nach-Links drückt kommt man nur zur Parent-Node wenn es das erste Kind-Element ist. Ist man z.B. auf dem zweiten Unterelement in einer Ebene springt der Fokus mit Pfeil-Nach-Links zum Unterelement davor, statt auf den Parent.

@laske185
Copy link
Contributor

Änderung:

  • Mit Pfeil-Taste-Links springt man immer zum Parent-Node, wenn der aktuelle Knoten nicht aufgeklappt ist
    Beispiel in Demo-App:
  • Fokus auf 3.1.2 Coffee makers
  • Pfeil Links
  • Fokus geht zu 3.1Home

@laske185 laske185 merged commit 35dca9c into develop May 30, 2024
5 checks passed
@laske185 laske185 deleted the 6160-keyboard-shotcuts-tree-navigation branch May 30, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laske185 laske185 laske185 approved these changes

@sdvg sdvg sdvg left review comments

Assignees

@AntnSaj AntnSaj

@anicyne anicyne

@fohi17 fohi17

Labels
a11y-retest
Projects
KoliBri Board
Status: 🔍 Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tree - Keyboard-Shortcuts
6 participants
@anicyne @deleonio @fohi17 @laske185 @sdvg @AntnSaj