Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified function getCmPerPixel to es6 funcion in src/util/ImageUtil.js #1166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kabuur
Copy link

@kabuur kabuur commented Oct 15, 2022

鈥il.js

Fixes #598 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@gitpod-io
Copy link

gitpod-io bot commented Oct 15, 2022

@kabuur
Copy link
Author

kabuur commented Oct 15, 2022

Modified function to es6 funcion in src/util/ImageUtil.js]

getCmPerPixel(overlay) {
var map = overlay._map;
getCmPerPixel:((overlay)=> {
let map = overlay._map;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think it could be const perhaps? And on line 6 as well, if I understand right!

Thank you for your help!!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kabuur would you mind making this change and then hopefully we can merge this! Thank you!

Suggested change
let map = overlay._map;
const map = overlay._map;

@kabuur kabuur requested a review from jywarren October 17, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants