Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the missing closing body tags to export.html and select.html #1227

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abba-danmusa
Copy link

@abba-danmusa abba-danmusa commented Oct 23, 2022

Fixes #0000 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Oct 23, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2022

@cesswairimu
Copy link
Collaborator

hi @abba-danmusa , could you please add the link to the issue you are fixing with this PR

@abba-danmusa
Copy link
Author

abba-danmusa commented Oct 24, 2022 via email

@abba-danmusa
Copy link
Author

#1218

@abba-danmusa
Copy link
Author

This is the link to the issue #1218

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abba-danmusa could you please check your changes? it seems you touched lines that were not part of the issue

@abba-danmusa
Copy link
Author

@abba-danmusa could you please check your changes? it seems you touched lines that were not part of the issue

Okay. Am on it

@abba-danmusa
Copy link
Author

@abba-danmusa could you please check your changes? it seems you touched lines that were not part of the issue

Fixed

@abba-danmusa
Copy link
Author

Hi cesswairimu, can you please approve this?
Thank you.

@cesswairimu
Copy link
Collaborator

hi @abba-danmusa, I am sorry, it seems the issue you are solving was fixed on this pull request #1247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants