Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get title of Image on URL and display on sidebar #1238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Chinazaekpere-Ike
Copy link

@Chinazaekpere-Ike Chinazaekpere-Ike commented Oct 25, 2022

I have fetched the name of the image from the inputted URL. This is the same name which the user originally saved their image on archive.org

This gotten image name s now displayed on the sidebar (beneath the gotten image) as the Image title

Fixes #1202

I @Chinazaekpere-Ike is the author of the issue

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updates
  • @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

20221021_004616

@jywarren Hope this looks good.

@welcome
Copy link

welcome bot commented Oct 25, 2022

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2022

@jywarren
Copy link
Member

jywarren commented Nov 2, 2022

Hello, this looks good, i like it! What if we placed the title just above the "Place on map" button, though... could it be more compact that way? Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get title of Image on URL and display on sidebar
2 participants