Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the Side-NavBar, fixes #339 #343

Closed
wants to merge 1 commit into from
Closed

Added the Side-NavBar, fixes #339 #343

wants to merge 1 commit into from

Conversation

DevanshCodes
Copy link
Member

@DevanshCodes DevanshCodes commented Feb 20, 2020 •
edited

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes Adding Side-Navbar for better usability #339 -style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@DevanshCodes DevanshCodes mentioned this pull request Feb 20, 2020
Open
@cesswairimu
Copy link

Hi @DevanshCodes, thanks so much for opening this 🎉 could you please add the issue link to the issue this pull request fixes on your pull request on this line "Fixes issue_link" this will help other contributors while reviewing your changes. It also helps in automatically closing the issue when the pull request is merged. Thanks

@Rishabh570
Copy link
Collaborator

Hi @DevanshCodes, can you please share a screenshot of your changes. Also, which issue does this PR point to? It would be great if you can reference issues in your PR desc. (Like Fixes #{issue_number}).

Thanks!

@DevanshCodes
Copy link
Member Author

DevanshCodes commented Feb 26, 2020 •
edited

Hey @Rishabh570 , sorry for the description, fixed that. Here's the screenshot.

sidenav_send

Thanks! :)

VladimirMikulic
VladimirMikulic suggested changes Feb 26, 2020
View reviewed changes
Copy link

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you hover over the sidebar link it becomes white(invisible). It should either change the colour or shade(become darker).

@Rishabh570
Copy link
Collaborator

Hi @DevanshCodes, this is very useful!
So, how does it behave on smaller screens...can you please share a GIF for that. Also, if you could fix the visibility issue when you hover over those links.

Thanks!!!

@jywarren
Copy link
Member

I agree this is super nice! And would love to see some different screen sizes. Thank you!!!

@jywarren
Copy link
Member

jywarren commented May 7, 2020

Hi, just wondering if a few other screen sizes could be included in screenshots? Thank you!

@DevanshCodes
Copy link
Member Author

Hey @jywarren , was busy for a month because I was applying for GSoC in other Org. Now, I'm free and will look into this.

@jywarren
Copy link
Member

jywarren commented May 8, 2020 via email

@jywarren
Copy link
Member

Hi, it looks like @YogeshSharma01 is working on a top navbar now. I'm going to close this but we'd still love your help! Thank you very much!

@jywarren jywarren closed this Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirMikulic VladimirMikulic VladimirMikulic requested changes

@jywarren jywarren Awaiting requested review from jywarren

@Rishabh570 Rishabh570 Awaiting requested review from Rishabh570

@cesswairimu cesswairimu Awaiting requested review from cesswairimu

Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding Side-Navbar for better usability
5 participants
@DevanshCodes @cesswairimu @Rishabh570 @jywarren @VladimirMikulic