New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an alphabetic check for submissions #1953
base: master
Are you sure you want to change the base?
Conversation
Add alphabetic check
Not a part of this project, but I think it would be valuable to add this to It's beneficial to ensure all tests are run as part of |
Domains sorted by the ruby script linked from the docs:
Which makes this script complain:
I think the ruby script is wrong. It sorts cdn77-ssl before cdn77 because You get the same behavior with this Python code:
while what we want is
|
This PR attempts to add a check that will assess whether the "business name" of entries in the private domain are in alphabetical order, and that the domains listed under each entry are in the correct order at time of submission.
The check contained here attempts to use a regular expression to identify entries into the private domains list. However, this is not perfect - it seems like there is some inconsistency with the formatting of entries, making it difficult to pick a perfect way of identifying entries in the current list. The current expression identifies the vast majority of entries from what I can tell, but happy to use an alternative method if one exists.
Additionally, while creating this check it became apparent that there are currently many entries in the list that are not sorted correctly according to the existing guidelines. I'm happy to re-sort the list accordingly in this PR or in a preceding PR before this is merged.