Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to rollup to tackle large bundle size #94

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jburghardt
Copy link

This would switch from browserify to rollup and only bundle neccessary code from crypto.

package.json Outdated Show resolved Hide resolved
@jburghardt
Copy link
Author

node js 6 & 8 build still fail , see https://travis-ci.org/github/puleos/object-hash/builds/701670409

@darscan
Copy link

darscan commented Jun 24, 2020

node js 6 & 8 build still fail , see https://travis-ci.org/github/puleos/object-hash/builds/701670409

Yep, rollup needs Node 10+: rollup/rollup#3346 Which makes things tricky.. I guess you'd want to "build" on 10/12, but then test the output on 6, 8, 10 etc, so you'd need to change the Travis config to do that.

@addaleax
Copy link
Collaborator

To be honest, I would probably release this as a semver-major change anyway. You might as well drop unsupported Node.js versions from the CI matrix.

@jburghardt
Copy link
Author

then it be better to completely drop gulp in favor of npm scripts and rollup

@addaleax
Copy link
Collaborator

Yeah, I’m definitely okay with that too. But really, I’m just glad to accept PRs here :)

@sheff146
Copy link

sheff146 commented Feb 4, 2021

Hi. I see that this PR is present here for some time. Any ETA on when this great improvement is going to be merged and released?

@jburghardt
Copy link
Author

There are still issues with this pull request. i'm unable to find the time to fix this right now, feel free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants