Regenerate Python docs for all packages #3175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your site preview for commit aad4551 is now available! 🍹 http://content-bucket-b1cd31a.s3-website-us-east-1.amazonaws.com Deploy previews powered by Pulumify |
justinvp
reviewed
Apr 30, 2020
![pulumi[bot]](https://avatars.githubusercontent.com/in/15540?s=60&v=4){kind=small}
There was a problem hiding this comment.
🍹 The Update (preview) for stack pulumi/www.pulumi.com/production was successful.
Resource Changes
Name Type Operation
* archive-handler aws:ecs/taskDefinition:TaskDefinition replaced
~ archive-bucket-callback aws:lambda/function:Function update
~ archive-bucket-subscription aws:s3/bucketNotification:BucketNotification update
>- default-vpc-public-0 aws:ec2/subnet:Subnet read
>- default-vpc-public-1 aws:ec2/subnet:Subnet read
>- default-vpc aws:ec2/vpc:Vpc read
|
Your site preview for commit 55c409a is now available! 🍹 http://content-bucket-b1cd31a.s3-website-us-east-1.amazonaws.com Deploy previews powered by Pulumify |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have Python 3.8 on my macOS and the version of Sphinx that we have pinned for
tools/pydocgendoes not work unless we upgrade Sphinx to v2.3.1 or later. See sphinx-doc/sphinx#6803. The fix was to disable parallel build in Sphinx on macOS for Python 3.8 sphinx-doc/sphinx#6879. I am not sure if we ever upgraded Sphinx before and if there are things to "watch out" for?Looking at the diffs, though, I see that the every property, class, method now gets the
pycss class as well. I also see that output properties have a type associated with it. Not sure if that is Sphinx doing that, or if we recently added those types. Those are the two things I noticed. If this is too much, I can switch to Python 3.7 and regenerate them.Lastly, you might be wondering what's up with the commit messages saying "NodeJS". Sigh. I wrote a little script to commit the files per-package and I wrote it for the other PR for the NodeJS docs, and forgot to change the commit message while generating the Python docs. I'll fix the commit messages when I "squash and merge", so please ignore the "typo" for now. :)