Skip to content

Commit

Permalink
Enroll aws_wafv2_rule_group in PlanResourceChange (#3948)
Browse files Browse the repository at this point in the history
WAFv2 RuleGroups used to have a perma diff for the rules property.
Enrolling the resource in PlanResourceChange fixes that.

Fixes #3306,
#3880,
#3190,
#3454
  • Loading branch information
flostadler committed May 15, 2024
1 parent 1a7cbd8 commit d820cca
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
4 changes: 0 additions & 4 deletions examples/examples_nodejs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -468,10 +468,6 @@ func TestAccWafV2(t *testing.T) {
})
skipRefresh(&test)

// TODO[pulumi/pulumi-aws#3190] there is a bug with non-empty diff after pulumi up.
test.AllowEmptyPreviewChanges = true
test.AllowEmptyUpdateChanges = true

integration.ProgramTest(t, &test)
}

Expand Down
1 change: 1 addition & 0 deletions provider/resources.go
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,7 @@ func ProviderFromMeta(metaInfo *tfbridge.MetadataInfo) *tfbridge.ProviderInfo {
switch s {
case "aws_ssm_document",
"aws_wafv2_web_acl",
"aws_wafv2_rule_group",
"aws_batch_job_definition":
return true
default:
Expand Down

0 comments on commit d820cca

Please sign in to comment.