Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the interface for ECS Container PortMapping with current options #3043

Merged

Conversation

chan-vince
Copy link
Contributor

Update the ECS Container PortMapping interface to add in some fields that are in the API but currently missing from the interface. More context provided in the issue #2968.

I have done what felt obvious which was to update the interface. However I'm not really familiar with the full codegen(?) or dev process so I wouldn't be surprised if this is just the first step. Happy to continue further work with a bit of guidance :)

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link

Hello and thank you for your pull request! ❤️ ✨
It looks like you're directly modifying files in the language SDKs, many of which are autogenerated.
Be sure any files you're editing do not begin with a code generation warning.
For generated files, you will need to make changes in resources.go instead, and generate the code.

@corymhall corymhall marked this pull request as ready for review March 27, 2024 14:31
@corymhall
Copy link
Contributor

/run-acceptance-tests

@corymhall corymhall self-assigned this Mar 27, 2024
@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8453518971

Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@corymhall
Copy link
Contributor

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8468147023

Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-vince thanks for the PR, sorry it took so long!

@corymhall corymhall merged commit 2ee8434 into pulumi:master Mar 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants