-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the interface for ECS Container PortMapping with current options #3043
Update the interface for ECS Container PortMapping with current options #3043
Conversation
PR is now waiting for a maintainer to run the acceptance tests. |
Hello and thank you for your pull request! ❤️ ✨ |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8453518971 |
…ainer-port-mapping
PR is now waiting for a maintainer to run the acceptance tests. |
/run-acceptance-tests |
Please view the PR build: https://github.com/pulumi/pulumi-aws/actions/runs/8468147023 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-vince thanks for the PR, sorry it took so long!
Update the ECS Container PortMapping interface to add in some fields that are in the API but currently missing from the interface. More context provided in the issue #2968.
I have done what felt obvious which was to update the interface. However I'm not really familiar with the full codegen(?) or dev process so I wouldn't be surprised if this is just the first step. Happy to continue further work with a bit of guidance :)