Use new docker build provider #1278
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
reviewed
May 7, 2024
There was a problem hiding this comment.
SDK types are unchanged -- those remain the old Docker API.
The @pulumi/docker typess don't show up in the public API of this component, right? So what do you mean that "SDK types are unchanged"? I assume we can remove the dependency on @pulumi/docker from both the implementation, and update the implied depdendency in the schema (which I assume is only to hint at the internal dependnecy - even though not strictly needed?). Feel like maybe I'm missing something that motivated this comment though?
| @@ -22,8 +22,9 @@ | |||
| }, | |||
| "//": "Pulumi sub-provider dependencies must be pinned at an exact version because we extract this value to generate the correct dependency in the schema", | |||
| "dependencies": { | |||
| "@pulumi/aws": "6.32.0", | |||
| "@pulumi/aws": "6.9.0", | |||
| "@pulumi/docker": "4.5.1", | |||
There was a problem hiding this comment.
Can we remove this dependency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick POC replacing the old Docker provider with the new Docker Build provider.
SDK types are unchanged -- those remain the old Docker API.
Behavior is unchanged, except we will now automatically store and use an inline cache if the user hasn't configured anything explicitly.