Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name subnets after the AZ they are deployed in. #917

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jkodroff
Copy link
Member

Fixes #913

Note that this change, as implemented, will cause a replace for existing resources as the name of the resource is currently tied to the Name tag. Happy to separate the two based on PR feedback, or we can include a release note indicating how to alias to prevent the replace.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@guineveresaenger
Copy link

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/3138781987

@jkodroff
Copy link
Member Author

@lukehoban Do you have any thoughts on how we should communicate this change to users: Are migration (alias) instructions sufficient?

awsx/ec2/subnetDistributor.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@jkodroff
Copy link
Member Author

jkodroff commented Aug 28, 2023

@danielrbradley It's been dormant for a while, but I picked this back up and added the aliases. Unit tests look like they pass and I just need to run it against a test Pulumi program made before this change to ensure no resources get re-created.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great with the aliases added in! Let me know once you've confirmed the upgrade path works without recreation and I'll approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPC 1.0 Usability: Change naming of subnets from 1, 2, 3 to match AZ?
3 participants