-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name subnets after the AZ they are deployed in. #917
base: master
Are you sure you want to change the base?
Conversation
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
/run-acceptance-tests |
Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/3138781987 |
@lukehoban Do you have any thoughts on how we should communicate this change to users: Are migration (alias) instructions sufficient? |
b4d1ab4
to
84ee620
Compare
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
@danielrbradley It's been dormant for a while, but I picked this back up and added the aliases. Unit tests look like they pass and I just need to run it against a test Pulumi program made before this change to ensure no resources get re-created. |
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great with the aliases added in! Let me know once you've confirmed the upgrade path works without recreation and I'll approve.
Fixes #913
Note that this change, as implemented, will cause a replace for existing resources as the name of the resource is currently tied to the
Name
tag. Happy to separate the two based on PR feedback, or we can include a release note indicating how to alias to prevent the replace.