Fix nightly-sdk-generation #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 52c5108.
Does the PR have any schema changes?Looking good! No breaking changes found. |
but not enough @danielrbradley :) It's still failing, see the PR description. Latest run. |
thomas11
added
the
impact/no-changelog-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This nightly job started failing a few days ago, probably due to the merge of #1975.
The commits so far fix
make cleandoes.find bin ...fails on a fresh clone with nobin.pulumictl get versionfails because the Git clone has no tagsStill failing at this point:
local_generate, with many errors like this:Unfortunately, adding the
fetch_depth: 0option to the git checkout step adds about six minutes. But it's currently the only way to get tags, until the GH maintainers stop ignoring this.