Support invokes with non-object outputs, via wrapping #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. New functions:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
+ Coverage 55.04% 55.25% +0.21%
==========================================
Files 66 66
Lines 9857 9908 +51
==========================================
+ Hits 5426 5475 +49
+ Misses 4002 4001 -1
- Partials 429 432 +3 ☔ View full report in Codecov by Sentry. |
thomas11
changed the title
danielrbradley
approved these changes
Mar 21, 2024
thomas11
force-pushed
the
tkappler/non-object-invokes
branch
from
7bd61a9
to
fb1a6e2
Compare
If the schema has no properties but is a primitive output, we include it as a property so invokes can be generated. Ideally we'd just represent it as a primitive type and use FunctionSpec.ReturnType to specify this, but pulumi/pulumi 15739 and 15738 prevent this. Unfortunately, this required adding an unfortunate third boolean param to genProperties to limit this new case to function responses only.
Since commit 308846d requires the non-object responses to be wrapped in a certain object, ResourceCrudClient does that.
thomas11
force-pushed
the
tkappler/non-object-invokes
branch
from
fb1a6e2
to
5c49672
Compare
| func (m *moduleGenerator) genProperties(resolvedSchema *openapi.Schema, isOutput, isType, isResponse bool) (*propertyBag, error) { | ||
| // genPropertiesVariant is a set of flags that control the behavior of property generation | ||
| // in genProperties and genProperty | ||
| type genPropertiesVariant struct { |
danielrbradley
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3147
If we're generating response properties and the resolved schema has no properties but is a primitive/array output, we include it as a special property so invokes can be generated.
Ideally we'd just represent the response as a primitive type without the wrapping magic property, using
FunctionSpec.ReturnType, but pulumi/pulumi#15738 and pulumi/pulumi#15739 prevent this.Unfortunately, this change required adding a third boolean to
genPropertiesto limit this new case to function responses only. Happy to incorporate suggestions to model this better.This is a simple program that demonstrates one of the new invokes.
Output: