handle potential cgo dependencies #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixler
changed the title
dixler
force-pushed
the
dixler/127/go-cgo
branch
from
b7e249a
to
4a796dd
Compare
abhinav
approved these changes
Mar 3, 2023
The Go tests being green indicates that it fixes it. So I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gcc to the Go docker images to handle potential pulumi or pulumi test cgo dependencies that are breaking builds.
Part of #127
I'm still seeing issues with Go builds being broken.
https://github.com/pulumi/pulumi-docker-containers/actions/runs/4319115397
Might as well add gcc to make these containers less fragile in the future.
Thoughts?