Update Pulumi projects to net6.0 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
hah null reference checks are now running, got some annotations to add it seems |
Frassle
force-pushed
the
fraser/rmdotnetcore31
branch
2 times, most recently
from
4ce2a40
to
5d5070f
Compare
|
🍹 The Update for pulumi/testproj/daslbgag was successful. Resource Changes Name Type Operation
+ testproj-daslbgag pulumi:pulumi:Stack create
|
This comment has been minimized.
This comment has been minimized.
|
🍹 The Update for pulumi/testproj/qwzvzuhy was successful. Resource Changes Name Type Operation
+ testproj-qwzvzuhy pulumi:pulumi:Stack create
|
|
🍹 The Update for pulumi/testproj/xdoeeqyu was successful. Resource Changes Name Type Operation
+ testproj-xdoeeqyu pulumi:pulumi:Stack create
|
|
🍹 The Update (preview) for pulumi/testproj/xdoeeqyu was successful. Resource Changes Name Type Operation
+ testproj-xdoeeqyu pulumi:pulumi:Stack create
|
Frassle
force-pushed
the
fraser/rmdotnetcore31
branch
from
5d5070f
to
811e2af
Compare
.NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates the core porjects to only 6.0 as well. We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.
Frassle
force-pushed
the
fraser/rmdotnetcore31
branch
from
811e2af
to
fb505e6
Compare
Frassle
commented
Dec 22, 2022
| @@ -285,7 +267,8 @@ public sealed class Output<T> : IOutput | |||
|
|
|||
| if (Deployment.TryGetInternalInstance(out var instance)) | |||
| { | |||
| instance.Runner.RegisterTask(TypeNameHelper.GetTypeDisplayName(GetType(), false), dataTask); | |||
| var description = GetType().ToString(); | |||
There was a problem hiding this comment.
TypeNameHelper doesn't exist in 6.0 (Looks like it got made internal)
|
🍹 The Update for pulumi/testproj/uerdjhlh was successful. Resource Changes Name Type Operation
+ testproj-uerdjhlh pulumi:pulumi:Stack create
|
This comment has been minimized.
This comment has been minimized.
|
🍹 The Update for pulumi/testproj/xkahpywj was successful. Resource Changes Name Type Operation
+ testproj-xkahpywj pulumi:pulumi:Stack create
|
|
🍹 The Update for pulumi/testproj/qssshiol was successful. Resource Changes Name Type Operation
+ testproj-qssshiol pulumi:pulumi:Stack create
|
|
🍹 The Update (preview) for pulumi/testproj/qssshiol was successful. Resource Changes Name Type Operation
+ testproj-qssshiol pulumi:pulumi:Stack create
|
Zaid-Ajaj
approved these changes
Dec 28, 2022
Frassle
added a commit
that referenced
this pull request
Jan 4, 2023
This reverts commit e06f542. This is needed to give providers time to upgrade codegen. We messed up the ordering here thinking we needed to release a 6.0 library, but we can update the provider libraries to 6.0 and have them consume Pulumi.nuget at 3.1. This now multitargets net6.0 and netcoreapp3.1.
Frassle
added a commit
that referenced
this pull request
Jan 4, 2023
This reverts commit e06f542. This is needed to give providers time to upgrade codegen. We messed up the ordering here thinking we needed to release a 6.0 library, but we can update the provider libraries to 6.0 and have them consume Pulumi.nuget at 3.1. This now multitargets net6.0 and netcoreapp3.1.
bors bot
added a commit
to pulumi/pulumi
that referenced
this pull request
Jan 4, 2023
11543: Update Pulumi codegen to net6.0 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> .NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well. We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11766: Changelog and go.mod updates for v3.51.0 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Fraser Waters <fraser@pulumi.com> Co-authored-by: github-actions <github-actions@github.com>
Frassle
added a commit
that referenced
this pull request
Jan 4, 2023
This reverts commit e06f542. This is needed to give providers time to upgrade codegen. We messed up the ordering here thinking we needed to release a 6.0 library, but we can update the provider libraries to 6.0 and have them consume Pulumi.nuget at 3.1.
Frassle
added a commit
that referenced
this pull request
Jan 4, 2023
This reverts commit e06f542. This is needed to give providers time to upgrade codegen. We messed up the ordering here thinking we needed to release a 6.0 library, but we can update the provider libraries to 6.0 and have them consume Pulumi.nuget at 3.1.
bors bot
added a commit
to pulumi/pulumi
that referenced
this pull request
Jan 4, 2023
11543: Update Pulumi codegen to net6.0 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> .NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well. We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11766: Changelog and go.mod updates for v3.51.0 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Fraser Waters <fraser@pulumi.com> Co-authored-by: github-actions <github-actions@github.com>
bors bot
added a commit
to pulumi/pulumi
that referenced
this pull request
Jan 4, 2023
11543: Update Pulumi codegen to net6.0 r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> .NET Core 3.1 is out of support on December 13th: https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well. This updates sdkgen to only 6.0 as well. We'll need to ensure the version number in pkg/codegen/dotnet/gen.go matches the version number that pulumi/pulumi-dotnet#10 release as. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET Core 3.1 is out of support on December 13th:
https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core
We've already stopped testing on .NET Core 3.1, and program gen has been targeting only 6.0 for a while now as well.
This updates the core porjects to only 6.0 as well.
We'll still want to do pulumi/pulumi#11543 in pu/pu to update sdkgen.