ci: Use actions/checkout for submodules #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our workflows have a manual step to download submodules for the repository. This has started failing for new PRs with an error like the following: ``` fatal: detected dubious ownership in repository at '/__w/pulumi-java/pulumi-java' To add an exception for this directory, call: git config --global --add safe.directory /__w/pulumi-java/pulumi-java ``` Although this can be fixed by marking the directory safe, it's entirely unnecessary because the actions/checkout GitHub Action supports checkout out submodules natively. This removes all `git submodule update --init --recursive` steps, opting into actions/checkout's submodules functionality instead.
abhinav
added
the
impact/no-changelog-required
|
Example failure: #972 |
Frassle
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our workflows have a manual step to download submodules
for the repository.
This has started failing for new PRs with an error like the following:
Although this can be fixed by marking the directory safe,
it's entirely unnecessary because the actions/checkout GitHub Action
supports checkout out submodules natively.
This removes all
git submodule update --init --recursivesteps,opting into actions/checkout's submodules functionality instead.