-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross test skip empty lists and strings #1911
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1911 +/- ##
==========================================
+ Coverage 60.23% 62.05% +1.81%
==========================================
Files 328 327 -1
Lines 44390 36928 -7462
==========================================
- Hits 26739 22914 -3825
+ Misses 16152 12515 -3637
Partials 1499 1499 ☔ View full report in Codecov by Sentry. |
How are they broken? Examples? This sounds like a pretty severe assertion - I suspect if it was broken this badly we would have more end-user implications so perhaps this is a misunderstanding of the model in some form? |
I've added the tests in #1913 - wanted to keep the PRs fairly clean and self-contained. I think we get null vs empty wrong in a bunch of places and these are some of them. |
This one adds an escape hatch for empty strings and lists as these are currently broken.
I'll add the tests which repro this in the next PR.
Stacked on #1910