Deprecate fn::stackReference (#420)

pulumi · Dec 7, 2022 · 0af2103 · 0af2103
1 parent d3bedd9
commit 0af2103
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG_PENDING.md b/CHANGELOG_PENDING.md
@@ -1,3 +1,6 @@
 ### Improvements
 
+- Deprecate `fn::stackReference`.
+  [#420](https://github.com/pulumi/pulumi-yaml/pull/420)
+
 ### Bug Fixes
diff --git a/pkg/pulumiyaml/ast/expr.go b/pkg/pulumiyaml/ast/expr.go
@@ -774,6 +774,9 @@ func tryParseFunction(node *syntax.ObjectNode) (Expr, syntax.Diagnostics, bool)
 		set("fn::split", parseSplit)
 	case "fn::stackreference":
 		set("fn::stackReference", parseStackReference)
+		diags = append(diags, syntax.Warning(kvp.Key.Syntax().Range(),
+			`'fn::stackReference' is deprecated; please use 'pulumi:pulumi:StackReference' instead`,
+			`see "https://www.pulumi.com/docs/intro/concepts/stack/#stackreferences for more info.`))
 	case "fn::assetarchive":
 		set("fn::assetArchive", parseAssetArchive)
 	case "fn::secret":

diff --git a/pkg/pulumiyaml/run.go b/pkg/pulumiyaml/run.go
@@ -1376,6 +1376,10 @@ func (e *programEvaluator) evaluateExpr(x ast.Expr) (interface{}, bool) {
 	case *ast.AssetArchiveExpr:
 		return e.evaluateBuiltinAssetArchive(x)
 	case *ast.StackReferenceExpr:
+		e.addWarnDiag(x.Syntax().Syntax().Range(),
+			"'fn::stackReference' is deprecated",
+			"Please use `pulumi:pulumi:StackReference`; see"+
+				"https://www.pulumi.com/docs/intro/concepts/stack/#stackreferences")
 		return e.evaluateBuiltinStackReference(x)
 	case *ast.SecretExpr:
 		return e.evaluateBuiltinSecret(x)