Assume unknown key is project config key on convert #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iwahbe still looking into this right now, this gets past |
iwahbe
reviewed
Nov 2, 2022
pkg/pulumiyaml/sort.go
Outdated
| @@ -166,11 +167,18 @@ func topologicallySortedResources(t *ast.TemplateDecl, externalConfig []configNo | |||
|
|
|||
| e, ok := intermediates[name.Value] | |||
| if !ok { | |||
| diags.Extend(ast.ExprError(name, fmt.Sprintf("resource %q not found", name.Value), "")) | |||
| return false | |||
| if isPotentialConfig(name.Value) { | |||
There was a problem hiding this comment.
We will always need to generate the diagnostic. The difference is we will inject a dummy node instead of stopping the algorithm. The caller of topologicallySortedResources can then choose to ignore diags (which we will do for eject and get plugins, but nothing else).
Co-authored-by: Ian Wahbe <ian@wahbe.com>
aq17
added
the
impact/no-changelog-required
|
Closed in favor of #393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.