Re-enable go linter #436
Open
Re-enable go linter #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
added
kind/engineering
AaronFriel
approved these changes
Jan 24, 2023
iwahbe
commented
Jan 24, 2023
.github/workflows/stage-lint.yml
Outdated
| @@ -29,7 +29,7 @@ jobs: | |||
| - name: Lint | |||
| run: | | |||
| curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.49.0 | |||
| make lint-golang || true | |||
| make lint-golang | |||
There was a problem hiding this comment.
We were running the linter, then throwing away the result.
iwahbe
force-pushed
the
iwahbe/re-enable-go-linter
branch
2 times, most recently
from
9ba819f
to
1f05089
Compare
iwahbe
force-pushed
the
iwahbe/re-enable-go-linter
branch
from
1f05089
to
65aed4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the linter.