Add support for the deletedWith resource option
#437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/deletedwith
branch
from
8701da4
to
35b1448
Compare
This adds support for the `deletedWith` resource option that has recently been added to the Node.js, Python, .NET, and Go SDKs. In many cases there is no need to deleted resources if the container resource is going to be deleted as well. A few examples: - Database object (roles, tables) when database is being deleted - Cloud IAM bindings when user itself is being deleted This helps with: - Speeding the deletion process - Removing unnecessary calls to providers - Avoiding failed deletions when the pulumi user running the plan has access to the container resource but not the contained ones To avoid deleting contained resources, set the `deletedWith` resource option to the container resource.
justinvp
force-pushed
the
justin/deletedwith
branch
from
35b1448
to
463052a
Compare
iwahbe
approved these changes
Jan 28, 2023
aq17
reviewed
Jan 28, 2023
justinvp
commented
Jan 29, 2023
deletedWith is not a string URN, it's a resource
The test requires pulumi-std 0.1.0 and I can't quite figure out how to make the test work with the pre-release std library, so skipping for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
deletedWithresource option that has recently been added to the Node.js, Python, .NET, and Go SDKs.In many cases there is no need to deleted resources if the container resource is going to be deleted as well.
A few examples:
This helps with:
To avoid deleting contained resources, set the
deletedWithresource option to the container resource.Fixes #432