[area/nodejs] Take engines property into account when engine-strict a…

…ppear in .npmrc file (#9249)

* Take required nodejs version into account as specified in engine.node

* Simplify check for strict node engine

* Add changelog entry

* make linter happy

CHANGELOG_PENDING.md

@@ -18,6 +18,9 @@
 - [cli/plugins] - Improved error message for missing plugins.
   [#5208](https://github.com/pulumi/pulumi/pull/5208)
 
+- [sdk/nodejs] - Take engines property into account when engine-strict appear in npmrc file 
+  [#9249](https://github.com/pulumi/pulumi/pull/9249)
+
 ### Bug Fixes
 
 - [sdk/nodejs] - Fix uncaught error "ENOENT: no such file or directory" when an error occurs during the stack up.

sdk/nodejs/cmd/run/run.ts

@@ -17,6 +17,8 @@ import * as url from "url";
 import * as minimist from "minimist";
 import * as path from "path";
 import * as tsnode from "ts-node";
+import * as ini from "ini";
+import * as semver from "semver";
 import { parseConfigFileTextToJson } from "typescript";
 import { ResourceError, RunError } from "../../errors";
 import * as log from "../../log";
@@ -59,6 +61,28 @@ function packageObjectFromProjectRoot(projectRoot: string): Record<string, any>
     }
 }
 
+// Reads and parses the contents of .npmrc file if it exists under the project root
+// This assumes that .npmrc is a sibling to package.json
+function npmRcFromProjectRoot(projectRoot: string): Record<string, any>  {
+    const emptyConfig = {};
+    try {
+        const npmRcPath = path.join(projectRoot, ".npmrc");
+        if (!fs.existsSync(npmRcPath)) {
+            return emptyConfig;
+        }
+        // file .npmrc exists, read its contents
+        const npmRc = fs.readFileSync(npmRcPath, "utf-8");
+        // Use ini to parse the contents of the .npmrc file
+        // This is what node does as described in the npm docs
+        // https://docs.npmjs.com/cli/v8/configuring-npm/npmrc#comments
+        return ini.parse(npmRc);
+    } catch {
+        // .npmrc file exists but we couldn't read or parse it
+        // user out of luck here
+        return emptyConfig;
+    }
+}
+
 function throwOrPrintModuleLoadError(program: string, error: Error): void {
     // error is guaranteed to be a Node module load error. Node emits a very
     // specific string in its error message for module load errors, which includes
@@ -262,7 +286,8 @@ ${defaultMessage}`);
         // Now go ahead and execute the code. The process will remain alive until the message loop empties.
         log.debug(`Running program '${program}' in pwd '${process.cwd()}' w/ args: ${programArgs}`);
         try {
-            const packageObject = packageObjectFromProjectRoot(projectRootFromProgramPath(program));
+            const projectRoot = projectRootFromProgramPath(program);
+            const packageObject = packageObjectFromProjectRoot(projectRoot);
 
             let programExport: any;
 
@@ -296,6 +321,28 @@ ${defaultMessage}`);
                 programExport = require(program);
             }
 
+            // Check compatible engines before running the program:
+            const npmRc = npmRcFromProjectRoot(projectRoot);
+            if (npmRc["engine-strict"] && packageObject.engines && packageObject.engines.node) {
+                // found:
+                //   - { engines: { node: "<version>" } } in package.json
+                //   - engine-strict=true in .npmrc
+                //
+                // Check that current node version satistfies the required version
+                const requiredNodeVersion = packageObject.engines.node;
+                const currentNodeVersion = process.versions.node;
+                if (!semver.satisfies(currentNodeVersion, requiredNodeVersion)) {
+                    const errorMessage = [
+                        `Your current Node version is incompatible to run ${projectRoot}`,
+                        `Expected version: ${requiredNodeVersion} as found in package.json > engines > node`,
+                        `Actual Node version: ${currentNodeVersion}`,
+                        `To fix issue, install a Node version that is compatible with ${requiredNodeVersion}`,
+                    ];
+
+                    throw new Error(errorMessage.join("\n"));
+                }
+            }
+
             // If the exported value was itself a Function, then just execute it.  This allows for
             // exported top level async functions that pulumi programs can live in.  Finally, await
             // the value we get back.  That way, if it is async and throws an exception, we properly

sdk/nodejs/package.json

@@ -13,6 +13,7 @@
         "@logdna/tail-file": "^2.0.6",
         "@pulumi/query": "^0.3.0",
         "google-protobuf": "^3.5.0",
+        "ini": "^2.0.0",
         "js-yaml": "^3.14.0",
         "minimist": "^1.2.0",
         "normalize-package-data": "^2.4.0",
@@ -26,6 +27,7 @@
         "upath": "^1.1.0"
     },
     "devDependencies": {
+        "@types/ini": "^1.3.31",
         "@types/js-yaml": "^3.12.5",
         "@types/minimist": "^1.2.0",
         "@types/mocha": "^2.2.42",
@@ -36,12 +38,12 @@
         "@types/split2": "^2.1.6",
         "@typescript-eslint/eslint-plugin": "^4.29.0",
         "@typescript-eslint/parser": "^4.29.0",
-        "mockpackage": "file:tests/mockpackage",
         "eslint": "^7.32.0",
         "eslint-plugin-header": "^3.1.1",
         "eslint-plugin-import": "^2.23.4",
-        "nyc": "^15.1.0",
-        "mocha": "^9.0.0"
+        "mocha": "^9.0.0",
+        "mockpackage": "file:tests/mockpackage",
+        "nyc": "^15.1.0"
     },
     "pulumi": {
         "comment": "Do not remove. Marks this as as a deployment-time-only package"
@@ -53,6 +55,6 @@
         "require": ["ts-node/register", "source-map-support/register"]
     },
     "//": [
-       "NOTE: @types/node is pinned due to grpc/grpc-node#2002"
+        "NOTE: @types/node is pinned due to grpc/grpc-node#2002"
     ]
 }