revert(sdk/go): Revert changes to String & marshaling method receivers)

pulumi · Oct 11, 2022 · 4edd7ff · 4edd7ff
1 parent a09bb93
commit 4edd7ff
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/sdk/go/common/resource/config/key.go b/sdk/go/common/resource/config/key.go
@@ -70,7 +70,7 @@ func (k *Key) Name() string {
 	return k.name
 }
 
-func (k *Key) MarshalJSON() ([]byte, error) {
+func (k Key) MarshalJSON() ([]byte, error) {
 	return json.Marshal(k.String())
 }
 
@@ -90,7 +90,7 @@ func (k *Key) UnmarshalJSON(b []byte) error {
 	return nil
 }
 
-func (k *Key) MarshalYAML() (interface{}, error) {
+func (k Key) MarshalYAML() (interface{}, error) {
 	return k.String(), nil
 }
 
@@ -110,7 +110,7 @@ func (k *Key) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	return nil
 }
 
-func (k *Key) String() string {
+func (k Key) String() string {
 	return k.namespace + ":" + k.name
 }
 

diff --git a/sdk/go/common/resource/resource_id.go b/sdk/go/common/resource/resource_id.go
@@ -30,8 +30,8 @@ import (
 type ID string
 
 // String converts a resource ID into a string.
-func (id *ID) String() string {
-	return string(*id)
+func (id ID) String() string {
+	return string(id)
 }
 
 // StringPtr converts an optional ID into an optional string.

diff --git a/sdk/go/common/util/cmdutil/console.go b/sdk/go/common/util/cmdutil/console.go
@@ -152,7 +152,7 @@ func MeasureText(text string) int {
 	return uniseg.GraphemeClusterCount(clean)
 }
 
-func (table Table) ToStringWithGap(columnGap string) string {
+func (table *Table) ToStringWithGap(columnGap string) string {
 	columnCount := len(table.Headers)
 
 	// Figure out the preferred column width for each column.  It will be set to the max length of

diff --git a/sdk/go/common/workspace/plugins.go b/sdk/go/common/workspace/plugins.go
@@ -622,7 +622,7 @@ func (info *PluginInfo) Spec() PluginSpec {
 	return PluginSpec{Name: info.Name, Kind: info.Kind, Version: info.Version}
 }
 
-func (info *PluginInfo) String() string {
+func (info PluginInfo) String() string {
 	var version string
 	if v := info.Version; v != nil {
 		version = fmt.Sprintf("-%s", v)

diff --git a/sdk/go/common/workspace/project.go b/sdk/go/common/workspace/project.go
@@ -348,7 +348,7 @@ func (info *ProjectRuntimeInfo) SetOption(key string, value interface{}) {
 	info.options[key] = value
 }
 
-func (info *ProjectRuntimeInfo) MarshalYAML() (interface{}, error) {
+func (info ProjectRuntimeInfo) MarshalYAML() (interface{}, error) {
 	if info.options == nil || len(info.options) == 0 {
 		return info.name, nil
 	}
@@ -359,7 +359,7 @@ func (info *ProjectRuntimeInfo) MarshalYAML() (interface{}, error) {
 	}, nil
 }
 
-func (info *ProjectRuntimeInfo) MarshalJSON() ([]byte, error) {
+func (info ProjectRuntimeInfo) MarshalJSON() ([]byte, error) {
 	if info.options == nil || len(info.options) == 0 {
 		return json.Marshal(info.name)
 	}