Skip to content

Commit

Permalink
ci: Use macos-latest
Browse files Browse the repository at this point in the history
In #11155, we pinned CI to macos-11
because we want to continue to support macOS 11.

This, however hsa created a new issue:
grpcio does not publish wheels for macos-11 anymore
and building it from source takes long enough to kill our CI
(see #12054 #12050).

To fix the issue while continuing to support older macOS,
run CI on macos-latest, but leave build jobs and friends on macos-11.

Resolves #12054, #12050
  • Loading branch information
abhinav committed Feb 3, 2023
1 parent 486b364 commit 8adb856
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Expand Up @@ -117,8 +117,8 @@ jobs:
{ "os": "linux", "arch": "arm64", "build-platform": "ubuntu-latest" },
{ "os": "windows", "arch": "amd64", "build-platform": "ubuntu-latest" },
{ "os": "windows", "arch": "arm64", "build-platform": "ubuntu-latest" },
{ "os": "darwin", "arch": "amd64", "build-platform": "macos-11" },
{ "os": "darwin", "arch": "arm64", "build-platform": "macos-11" }
{ "os": "darwin", "arch": "amd64", "build-platform": "macos-latest" },
{ "os": "darwin", "arch": "arm64", "build-platform": "macos-latest" }
]'
fi
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/on-pr.yml
Expand Up @@ -69,7 +69,7 @@ jobs:
acceptance-test-platforms: >- # No newlines or trailing newline.
${{
contains(github.event.pull_request.labels.*.name, 'ci/test')
&& 'macos-11 windows-latest'
&& 'macos-latest windows-latest'
|| ''
}}
enable-coverage: true
Expand Down
2 changes: 1 addition & 1 deletion scripts/get-job-matrix.py
Expand Up @@ -88,7 +88,7 @@ class MakefileTest(TypedDict):
{"name": "sdk/nodejs sxs_tests", "run": "cd sdk/nodejs && ../../scripts/retry make sxs_tests", "eta": 3},
]

ALL_PLATFORMS = ["ubuntu-latest", "windows-latest", "macos-11"]
ALL_PLATFORMS = ["ubuntu-latest", "windows-latest", "macos-latest"]


MINIMUM_SUPPORTED_VERSION_SET = {
Expand Down

0 comments on commit 8adb856

Please sign in to comment.