Skip to content

Commit

Permalink
Merge #12603
Browse files Browse the repository at this point in the history
12603: Remove outdated comments r=Frassle a=mmdriley

The call to `SetModTime` was removed in #11002 but the comment stayed around. The `nolint` directive had been added in #1494 to excuse the (now-removed) use of `SetModTime`.


Co-authored-by: Matthew Riley <mdriley@gmail.com>
  • Loading branch information
bors[bot] and mmdriley committed Apr 5, 2023
2 parents 3459a76 + d8e2737 commit dc2871e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions sdk/go/common/resource/asset.go
Expand Up @@ -1047,9 +1047,7 @@ func addNextFileToZIP(r ArchiveReader, zw *zip.Writer, seenFiles map[string]bool

// Set a nonzero -- but constant -- modification time. Otherwise, some agents (e.g. Azure
// websites) can't extract the resulting archive. The date is comfortably after 1980 because
// the ZIP format includes a date representation that starts at 1980. Use `SetModTime` to
// remain compatible with Go 1.9.
//nolint:megacheck
// the ZIP format includes a date representation that starts at 1980.
fh.Modified = time.Date(1990, time.January, 1, 0, 0, 0, 0, time.UTC)

fw, err := zw.CreateHeader(fh)
Expand Down

0 comments on commit dc2871e

Please sign in to comment.