Provider downloads from a third party fails

[jaxxstorm]

What happened?

When trying to test the download of third-party plugins from GitHub, we get a 403 error.

These commands work fine locally.

Steps to reproduce

Enable the

await ws.installPluginFromServer("scaleway", "v1.2.0", "github://api.github.com/lbrlabs");

Test

Expected Behavior

It downloads the plugin

Actual Behavior

We get a 403

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[Frassle]

This might just have been rate limits? I wonder if we can pull the request body text off for that error to make it a bit more clear.

[RobbieMcKinstry]

Hey Lee! Do I understand this issue correctly?

1. Your goal is to programmatically download and install a plugin.
2. You can successfully install the plugin using local CLI commands.
3. This issue is about a related pull request.
4. Specifically, the above code await ws.installPluginFromServer("scaleway", "v1.2.0", "github://api.github.com/lbrlabs"); refers to this function defined in the PR.

[Frassle]

I think you could quibble over this being a bug or enhancement, I don't think we want to auto-retry all 403's in plugin install but that error message could be a lot better. Rather than just saying 403, github would have given some details in the http response as well but we don't bother looking at that.

[RobbieMcKinstry]

Ah, I see what you're getting at re: bug vs feature. I interpreted this issue as specifically a bug in the behavior of the AA function that Lee added in the linked PR. Whoops, I get it now.

[RobbieMcKinstry]

@Frassle would you agree that this is a usability consideration we could fix? It feels like the domain of "First 48H"-style usability and error message issues (I know that epic is done with, just trying to draw an analogy).

[Frassle]

Yes, it's just a very unhelpful error message.