Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new install plugin from server function #10955

Merged
merged 13 commits into from Oct 24, 2022
Merged

Add new install plugin from server function #10955

merged 13 commits into from Oct 24, 2022

Conversation

jaxxstorm
Copy link
Contributor

Add the ability to install plugins from a server.

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 7, 2022 •
edited

Changelog

[uncommitted] (2022-10-23)

Features

  • [auto/go] Add InstallPluginFromServer method
    #10955

  • [auto/nodejs] Add InstallPluginFromServer
    #10955

  • [auto/python] Add install_plugin_from_server
    #10955

@jaxxstorm jaxxstorm marked this pull request as ready for review October 12, 2022 18:17
Frassle
Frassle approved these changes Oct 12, 2022
View reviewed changes
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. It might be better to call it InstallProviderFromServer to be a bit more explicit its just for resource providers but then might lead to confusion between "plugin - resource" and "provider".

.github/workflows/ci-run-test.yml Outdated Show resolved Hide resolved
@RobbieMcKinstry RobbieMcKinstry mentioned this pull request Oct 17, 2022
Open
justinvp
justinvp reviewed Oct 19, 2022
View reviewed changes
sdk/nodejs/automation/localWorkspace.ts Show resolved Hide resolved
.github/workflows/ci-run-test.yml Outdated Show resolved Hide resolved
sdk/nodejs/automation/localWorkspace.ts Outdated Show resolved Hide resolved
sdk/python/lib/pulumi/automation/_local_workspace.py Show resolved Hide resolved
@jaxxstorm
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 24, 2022

Build succeeded:

@bors bors bot merged commit 7711564 into master Oct 24, 2022
@pulumi-bot pulumi-bot deleted the jaxxstorm/install_plugin_server branch October 24, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp left review comments

@AaronFriel AaronFriel AaronFriel left review comments

@Frassle Frassle Frassle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jaxxstorm @pulumi-bot @justinvp @AaronFriel @Frassle