New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hierarchical and structured config implementation: the initial pass #10832
Merged
Merged
Changes from 28 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6c6b5ce
Initial work on project-level config (MVP)
Zaid-Ajaj 683f7e1
Implement stack config validation and inheritance
Zaid-Ajaj f659376
Add description to the config type declaration
Zaid-Ajaj 966e96f
Apply project config to stack config when appropriate
Zaid-Ajaj aa648fd
Implement short-hand configuration value support
Zaid-Ajaj dff4079
support string, int and bool in shorthand config definitions
Zaid-Ajaj 6531b66
test config schemas that use short hand version
Zaid-Ajaj d419605
Moaar unit tests for config validation
Zaid-Ajaj 02bdbd0
changelog entry
Zaid-Ajaj 7975498
lint
Zaid-Ajaj 78ecb2b
Merge branch 'master' into minimal-config
Zaid-Ajaj 969e0e6
project.json should validate short-hand config syntax before rewritin…
Zaid-Ajaj 0498be1
Rewrite config to stackConfigDir when provided as string
Zaid-Ajaj 65cfee4
pulumi import uses hierarchical config
Zaid-Ajaj 5bd9b80
namespaced config values don't need the project as root namespace
Zaid-Ajaj fbc68cb
Project namespace is now optional when defining stack config
Zaid-Ajaj 77c7880
Fix reading empty project stack file
Zaid-Ajaj ae03899
Fix TestSecretsProviderOverride which requires both stack and project…
Zaid-Ajaj 46be886
lint
Zaid-Ajaj 2755638
Fix TestDestroyStackRef: don't change CWD and fix TestStackInitValida…
Zaid-Ajaj afeac6e
simplify test assert even more (attempt #3)
Zaid-Ajaj 9a9a39b
Make sure config defined by a stack are also defined by the project +…
Zaid-Ajaj c739adb
Fix tests that have incomplete project config. Correct docs for Creat…
Zaid-Ajaj 4cb2c19
Use "omit empty" for config types, add another integration test, chec…
Zaid-Ajaj 37730d4
Merge branch 'master' into minimal-config
Zaid-Ajaj 00f4ba3
Merge branch 'master' into minimal-config
Zaid-Ajaj 813ac76
Add array config to test that the array is marshalled/unmarshalled co…
Zaid-Ajaj 7c509d2
Assume configFile is non-empty
Zaid-Ajaj 0766b86
Merge branch 'master' into minimal-config
Zaid-Ajaj 12f3992
Revert changing the temp dir TestDestroyStackRef
Zaid-Ajaj c606757
fix TestProjectLoadYAML expected error messages
Zaid-Ajaj 42a51fe
Allow project to be nil when namespacing project stack config
Zaid-Ajaj 51b1329
remove readProject from getStackConfiguration and pass project from o…
Zaid-Ajaj fb11347
No need to rewrite project when validating project schema and refacto…
Zaid-Ajaj 58de26d
Don't know why the change in the project schema was reverted but here…
Zaid-Ajaj f2ac21f
Update changelog/pending/20220922--cli-initial-mvp-config.yaml
Frassle File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
changes: | ||
- type: feat | ||
scope: cli | ||
description: Implement initial MVP for hierarchical and structured project configuration | ||
Frassle marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.