Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more flexible parsing when extracting examples from descriptions #10913

Merged
merged 5 commits into from Oct 6, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 4, 2022

Description

Fixes #10614

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe self-assigned this Oct 4, 2022
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-10-04)

Bug Fixes

  • [docs] Allow more flexible parsing when extracting examples from doc comments
    #10913

Copy link
Contributor

@Zaid-Ajaj Zaid-Ajaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe
Copy link
Member Author

iwahbe commented Oct 6, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 6, 2022

Build succeeded:

@bors bors bot merged commit 3dc76a6 into master Oct 6, 2022
@bors bors bot deleted the iwahbe/10614/dont-drop-api-examples branch October 6, 2022 17:08
iwahbe added a commit that referenced this pull request Oct 10, 2022
10913: Allow more flexible parsing when extracting examples from descriptions r=iwahbe a=iwahbe

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Fixes #10614

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [X] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [X] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Ian Wahbe <ian@wahbe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We are dropping (many?) API docs due to parsing logic
3 participants