Add standardized program-gen reporting helpers #11032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-18)Features
|
aq17
approved these changes
Oct 14, 2022
AaronFriel
reviewed
Oct 17, 2022
pkg/codegen/report/report.go
Outdated
| } | ||
|
|
||
| // Report a new call to GenerateProgram. Every call should be reported. | ||
| func (r *reporter) Report(title, language string, files []*syntax.File, f GenerateProgramFn) GenerateProgramFn { |
There was a problem hiding this comment.
Include a unit test of the output?
AaronFriel
requested changes
Oct 17, 2022
iwahbe
force-pushed
the
iwahbe/10988/add-codegen-report
branch
from
1cb5a41
to
7785f31
Compare
Initial Report CL Fix timestamps Add files Add example
iwahbe
force-pushed
the
iwahbe/10988/add-codegen-report
branch
from
7785f31
to
b3a38cc
Compare
Examples have been added. |
AaronFriel
approved these changes
Oct 18, 2022
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a shared format for reporting codegen problems.
Description
Fixes #10988
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change