Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose LocalSerializer #11106

Merged
merged 2 commits into from Oct 31, 2022
Merged

Expose LocalSerializer #11106

merged 2 commits into from Oct 31, 2022

Conversation

ffMathy
Copy link
Contributor

@ffMathy ffMathy commented Oct 21, 2022 •
edited

Description

Use case: I want to be able to deserialize a Pulumi.stack.yml file without using a LocalWorkspace, as that requires too much configuration and isn't very well-documented.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@ffMathy
Expose LocalSerializer
c24259e 
**Use case:** I want to be able to deserialize a `Pulumi.stack.yml` file without using a `LocalWorkspace`, as that requires too much configuration and isn't very well-documented.
@github-actions
Copy link

PR is now waiting for a maintainer to take action.

Note for the maintainer: Commands available:

  • /run-acceptance-tests - used to test run the acceptance tests for the project
  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 21, 2022 •
edited

Changelog

[uncommitted] (2022-10-31)

Features

  • [sdk/dotnet] Make the LocalSerializer class public.

@ffMathy
Copy link
Contributor Author

ffMathy commented Oct 21, 2022

Hmmm, not sure how to run the changelog thing myself. Also curious as to why this is not done automatically by a CI/CD environment 🤔

@Frassle
Copy link
Member

Frassle commented Oct 24, 2022

not sure how to run the changelog thing myself

Run make changelog

Frassle
Frassle approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but out of interest why are you wanting to deserialize a Pulumi.stack.yml?

@ffMathy
Copy link
Contributor Author

ffMathy commented Oct 24, 2022

not sure how to run the changelog thing myself

Run make changelog

Do I need something installed for this? And can I run it on Windows?

@ffMathy
Copy link
Contributor Author

ffMathy commented Oct 24, 2022

This looks reasonable, but out of interest why are you wanting to deserialize a Pulumi.stack.yml?

I'm using Pulumi to bootstrap an AWS environment for every pull request that's opened for my project, with a certain resource name suffix named after the branch.

But when doing that, I want some additional settings that tell my Pulumi program to not include certain resources.

So I essentially want a copy of my existing stack, but with some settings modified.

And with Pulumi Automation, it's currently not possible to perform a copy operation etc.

@Frassle
Copy link
Member

Frassle commented Oct 24, 2022

Do I need something installed for this? And can I run it on Windows?

Should just need go and make. If it doesn't work just comment what you'd like it to say I can push a changelog commit for you.

But when doing that, I want some additional settings that tell my Pulumi program to not include certain resources.

Ah ok good context to know, I want to rework config manipulation from automation api at some point and I can keep that in mind.

@iwahbe
Copy link
Member

iwahbe commented Oct 31, 2022

bors r+

bors bot added a commit that referenced this pull request Oct 31, 2022
@bors @ffMathy @iwahbe
Merge #11106
30f9f34 
11106: Expose LocalSerializer r=iwahbe a=ffMathy

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description
**Use case:** I want to be able to deserialize a `Pulumi.stack.yml` file without using a `LocalWorkspace`, as that requires too much configuration and isn't very well-documented.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [X] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Mathias Lykkegaard Lorenzen <mathias.lorenzen@live.com>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Build failed:

@iwahbe
Copy link
Member

iwahbe commented Oct 31, 2022

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 31, 2022

Build succeeded:

@bors bors bot merged commit b7094ba into pulumi:master Oct 31, 2022
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@bors @ffMathy @iwahbe
Merge pulumi/pulumi#11106
9b28dcd 
11106: Expose LocalSerializer r=iwahbe a=ffMathy

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description
**Use case:** I want to be able to deserialize a `Pulumi.stack.yml` file without using a `LocalWorkspace`, as that requires too much configuration and isn't very well-documented.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [X] I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Mathias Lykkegaard Lorenzen <mathias.lorenzen@live.com>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frassle Frassle Frassle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ffMathy @pulumi-bot @Frassle @iwahbe