Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK/Python] Respect --parallel flag #11122

Merged
merged 3 commits into from Oct 22, 2022
Merged

[SDK/Python] Respect --parallel flag #11122

merged 3 commits into from Oct 22, 2022

Conversation

RobbieMcKinstry
Copy link
Contributor

@RobbieMcKinstry RobbieMcKinstry commented Oct 22, 2022 •
edited

Description

This PR sets the default futures executor to use the --parallel flag to determine thread count.

Fixes #1116

Checklist

  • I have added tests that prove my fix is effective or that my feature works. (Not unit tests, but I ran a thorough experiment.)
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@RobbieMcKinstry RobbieMcKinstry added kind/bug Some behavior is incorrect or out of spec area/sdks Pulumi language SDKs impact/performance Something is slower than expected language/python labels Oct 22, 2022
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Oct 22, 2022 •
edited

Changelog

[uncommitted] (2022-10-22)

Bug Fixes

  • [sdk/python] Python runtime now respects the --parallel flag.
    #11122

@RobbieMcKinstry RobbieMcKinstry marked this pull request as ready for review October 22, 2022 19:54
@RobbieMcKinstry RobbieMcKinstry linked an issue Oct 22, 2022 that may be closed by this pull request
[SDK/Python] Parallelism Flag Not Respected #11116
Closed
@RobbieMcKinstry
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 22, 2022

Build succeeded:

@bors bors bot merged commit f1c43a4 into master Oct 22, 2022
@bors bors bot deleted the mckinstry/python-concurrency branch October 22, 2022 23:54
This was referenced Oct 24, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frassle Frassle Frassle approved these changes

@kpitzen kpitzen Awaiting requested review from kpitzen

@Zaid-Ajaj Zaid-Ajaj Awaiting requested review from Zaid-Ajaj

Assignees
No one assigned
Labels
area/sdks Pulumi language SDKs impact/performance Something is slower than expected kind/bug Some behavior is incorrect or out of spec language/python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SDK/Python] Parallelism Flag Not Respected
3 participants
@RobbieMcKinstry @pulumi-bot @Frassle