Support future glob patterns #11150
Merged
Support future glob patterns #11150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-25)Features
|
Frassle
approved these changes
Oct 25, 2022
pkg/resource/deploy/deployment.go
Outdated
| } | ||
|
|
||
| // Return if the instance was explicitly created, or if it was default initialized. | ||
| func (t UrnTargets) IsInitialized() bool { |
There was a problem hiding this comment.
IsInitialized reads a bit odd, maybe IsEmpty? Because NewUrnTargets([]string{}) is initialized but would return false from this method.
There was a problem hiding this comment.
Good point. I'm going to change it to IsConstrained.
Conceptually, NewUrnTargets([]string{"foo*", "bar"}) is { urn | urn in Urns and (urn = "bar" or urn in expand("foo*")) } (urn is constrained).
NewUrnTargets([]string{}) is equivalent to { urn | urn in Urns } (urn is unconstrained).
|
It would be good to have a test for these new glob creates in pkg/engine/lifecycletest/target_test.go |
Support future glob patterns Improve name for unspecified targets Add a test in target_test
iwahbe
force-pushed
the
iwahbe/8956/support-future-glob-patterns
branch
from
0555d58
to
856bded
Compare
|
bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8956
This changes how the various
--targetglobs work. Instead of expanding the glob on the current snapshot, we now push the glob into the engine itself. This allows us to glob on resources not yet created.In exchange for this feature, we give up the ability to reject globs that expand to nothing ahead of running a pulumi up. We gain a much more intuitive interface: globs work as expected, without caveats.