Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent concurrent writes to the component providers map #11151

Merged
merged 1 commit into from Oct 25, 2022
Merged

Prevent concurrent writes to the component providers map #11151

merged 1 commit into from Oct 25, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 25, 2022 •
edited by lukehoban

Description

Fixes #11153.

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe requested a review from justinvp October 25, 2022 19:31
@iwahbe iwahbe self-assigned this Oct 25, 2022
@iwahbe iwahbe requested a review from aq17 October 25, 2022 19:31
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-10-25)

Bug Fixes

  • [engine] Prevent concurrent read/writes to the component providers map.
    #11151

justinvp
justinvp approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iwahbe
Copy link
Member Author

iwahbe commented Oct 25, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2022

Build succeeded:

@bors bors bot merged commit 0f24b84 into master Oct 25, 2022
@bors bors bot deleted the iwahbe/component-provider-map branch October 25, 2022 20:14
@Frassle Frassle mentioned this pull request Oct 26, 2022
Closed
@Zaid-Ajaj Zaid-Ajaj mentioned this pull request Oct 26, 2022
Closed
@iwahbe iwahbe mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@aq17 aq17 Awaiting requested review from aq17

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: concurrent map read and map write
3 participants
@iwahbe @pulumi-bot @justinvp