Add pulumi state delete --target-dependents
#11164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-10-27)Features
|
iwahbe
force-pushed
the
iwahbe/8458/state-delete--target-dependents
branch
from
d77d3b4
to
2d2c118
Compare
Frassle
approved these changes
Oct 27, 2022
kpitzen
approved these changes
Oct 27, 2022
Add comment + fix tests We had two problems here. 1. Our graph rapid tests didn't encode the `includeChildren` flag as transitive, which it should be. Looking at the call sites of `DependingOn` confirms this. 2. `TestDeleteProtected` was sharing variables between threads (causing flakey results). This was fixed.
iwahbe
force-pushed
the
iwahbe/8458/state-delete--target-dependents
branch
from
38f1570
to
0582242
Compare
|
bors r+ |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8458