New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[auto/python] Support for remote operations #11174
Conversation
Changelog[uncommitted] (2022-10-28)Features
|
summary = self.info(show_secrets) | ||
# If it's a remote workspace, explicitly set show_secrets to False to prevent attempting to | ||
# load the project file. | ||
summary = self.info(show_secrets and not self._is_remote) | ||
assert summary is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this isn't part of the PR, but should we really have asserts in production code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as we are asserting on our own logic (not user input), I think its fine. A Exception
is better than misunderstanding what is going on and potentially doing the wrong thing.
322227c
to
c4b7e64
Compare
c4b7e64
to
5657959
Compare
bors merge |
Build succeeded: |
This change adds preview support for remote operations in Python's Automation API.
Here's an example of using it:
I will add sanity tests subsequently.