Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Fix issue with pulumi new and unstaged files #11175

Merged
merged 1 commit into from Oct 27, 2022
Merged

cli: Fix issue with pulumi new and unstaged files #11175

merged 1 commit into from Oct 27, 2022

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Oct 27, 2022

Description

Fixes #11121

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@Frassle Frassle requested a review from justinvp October 27, 2022 21:39
@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-10-27)

Bug Fixes

  • [cli] Hard reset the templates checkout to work around a go-git issue with ignored files.
    #11175

justinvp
justinvp approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd tested this out very quickly last night in a test template repository I used to reproduce the issue, and it fixed the problem for me. But haven't really put it through its paces beyond that. If it LG to you, LGTM.

@Frassle
Copy link
Member Author

Frassle commented Oct 27, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 27, 2022

Build succeeded:

@bors bors bot merged commit ab21df6 into master Oct 27, 2022
@bors bors bot deleted the justin/gitreset branch October 27, 2022 22:35
@justinvp justinvp mentioned this pull request Dec 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@kpitzen kpitzen kpitzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulumi new hitting error: cloning templates repo: worktree contains unstaged changes
4 participants
@Frassle @pulumi-bot @justinvp @kpitzen