Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for duplicate aliases and plain URNs #11212

Merged
merged 1 commit into from Nov 1, 2022
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 1, 2022

Description

We need to check that for example that if a resource X is created that we don't allow another resource Y to be alias against X. Likewise if our old state has X and we then create Y aliased against X we should not then allow X to be created later in the deployment.

Fixes #11173

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 1, 2022

Changelog

[uncommitted] (2022-11-01)

Bug Fixes

  • [engine] Expand duplicate URN checks across direct URNs and aliases.
    #11212

We need to check that for example that if a resource X is created that
we don't allow another resource Y to be alias against X. Likewise if our
old state has X and we then create Y aliased against X we should not
then allow X to be created later in the deployment.

Fixes #11173
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. LGTM

@Frassle
Copy link
Member Author

Frassle commented Nov 1, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 1, 2022

Build succeeded:

@bors bors bot merged commit 6754c38 into master Nov 1, 2022
@pulumi-bot pulumi-bot deleted the fraser/duplicateAlias branch November 1, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aliasing allows two definitions of the same resource to be applied
3 participants