Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen/go: Remove superfluous newline in doc.go #11331

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
changes:
- type: fix
scope: sdkgen/go
description: Fixes superfluous newline being added between documentation comment and package statement in doc.go
5 changes: 3 additions & 2 deletions pkg/codegen/go/gen.go
Original file line number Diff line number Diff line change
Expand Up @@ -838,6 +838,9 @@ func (pkg *pkgContext) toOutputMethod(t schema.Type) string {
return "To" + outputTypeName
}

// printComment filters examples for the Go languages and prepends double forward slash to each line in the given
// comment. If indent is true, each line is indented with tab character. It returns the number of lines in the
// resulting comment. It guarantees that each line is terminated with newline character.
func printComment(w io.Writer, comment string, indent bool) int {
comment = codegen.FilterExamples(comment, "go")

Expand Down Expand Up @@ -1312,7 +1315,6 @@ func (pkg *pkgContext) fieldName(r *schema.Resource, field *schema.Property) str

func (pkg *pkgContext) genPlainType(w io.Writer, name, comment, deprecationMessage string,
properties []*schema.Property) {

printCommentWithDeprecationMessage(w, comment, deprecationMessage, false)
fmt.Fprintf(w, "type %s struct {\n", name)
for _, p := range properties {
Expand Down Expand Up @@ -3602,7 +3604,6 @@ func GeneratePackage(tool string, pkg *schema.Package) (map[string][]byte, error
} else {
fmt.Fprintf(buffer, "// Package %[1]s exports types, functions, subpackages for provisioning %[1]s resources.\n", name)
}
fmt.Fprintf(buffer, "\n")
fmt.Fprintf(buffer, "package %s\n", name)

setFile(path.Join(mod, "doc.go"), buffer.String())
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// A native Pulumi package for creating and managing Azure resources.

package azure
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package foo exports types, functions, subpackages for provisioning foo resources.

package foo
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package plantprovider exports types, functions, subpackages for provisioning plantprovider resources.

package plantprovider
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package plant exports types, functions, subpackages for provisioning plant resources.

package plant
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package mypkg exports types, functions, subpackages for provisioning mypkg resources.

package mypkg
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package repro exports types, functions, subpackages for provisioning repro resources.

package repro
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package repro exports types, functions, subpackages for provisioning repro resources.

package repro
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package registrygeoreplication exports types, functions, subpackages for provisioning registrygeoreplication resources.

package registrygeoreplication
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package repro exports types, functions, subpackages for provisioning repro resources.

package repro
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package foo exports types, functions, subpackages for provisioning foo resources.

package foo
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package foo exports types, functions, subpackages for provisioning foo resources.

package foo
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package myedgeorder exports types, functions, subpackages for provisioning myedgeorder resources.

package myedgeorder
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package mypkg exports types, functions, subpackages for provisioning mypkg resources.

package mypkg
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package mypkg exports types, functions, subpackages for provisioning mypkg resources.

package mypkg
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package foo exports types, functions, subpackages for provisioning foo resources.

package foo
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package xyz exports types, functions, subpackages for provisioning xyz resources.

package xyz
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package configstation exports types, functions, subpackages for provisioning configstation resources.

package configstation
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package mongodbatlas exports types, functions, subpackages for provisioning mongodbatlas resources.

package mongodbatlas
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package world exports types, functions, subpackages for provisioning world resources.

package world
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package my8664 exports types, functions, subpackages for provisioning my8664 resources.

package my8664
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package my8110 exports types, functions, subpackages for provisioning my8110 resources.

package my8110
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package mypkg exports types, functions, subpackages for provisioning mypkg resources.

package mypkg
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package plant exports types, functions, subpackages for provisioning plant resources.

package plant
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package different exports types, functions, subpackages for provisioning different resources.

package different
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
// Package example exports types, functions, subpackages for provisioning example resources.

package example