New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature - Short Node Label for Stack Graph #11383
Conversation
Changelog[uncommitted] (2022-12-13)Features
|
/run-acceptance-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks short and sweet. I left one nit on the help text, but otherwise it looks ready to merge.
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bors r+ |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
/run-acceptance-tests |
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
bors merge |
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
/rebase |
97fa845
to
0a1b478
Compare
/rebase-autosquash |
0a1b478
to
829cae4
Compare
bors merge |
Stopped waiting for PR status (GitHub check) without running due to duplicate requests to run. You may check Bors to see that this PR is included in a batch by one of the other requests. |
Build succeeded: |
Description
This feature allows the user to opt for short node labels, i.e, only the resource name part of the URN instead of the full URN that is returned as the node label in the stack graph while using
pulumi stack graph
command. A flag namedshort-node-name
is added to thepulumi stack graph
command that enables this feature.Command Usage
Existing command :
pulumi stack graph [file-name]
Example :
pulumi stack graph dev
Output for dev :
strict digraph {
Resource0 [label="urn:pulumi:dev::Test-Simple-Stack::pulumi:pulumi:Stack::Test-Simple-Stack-dev"];
Resource1 [label="urn:pulumi:dev::Test-Simple-Stack::pulumi:providers:aws-native::default_0_40_2"];
Resource2 [label="urn:pulumi:dev::Test-Simple-Stack::aws-native:s3:Bucket::my-bucket2"];
Resource2 -> Resource0 [color = "#AA6639"];
Resource3 [label="urn:pulumi:dev::Test-Simple-Stack::aws-native:s3:Bucket::my-bucket1"];
Resource3 -> Resource0 [color = "#AA6639"];
}
Command for using the feature :
pulumi stack graph [file-name] --short-node-name
Fixes #10663
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my change