Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add . between ? and ] #11477

Merged
merged 1 commit into from Nov 28, 2022
Merged

Add . between ? and ] #11477

merged 1 commit into from Nov 28, 2022

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 28, 2022

Fixes #8068

@iwahbe iwahbe self-assigned this Nov 28, 2022
@iwahbe iwahbe force-pushed the iwahbe/8068/ts-dot-optionals branch from 6f01013 to 25e4c49 Compare November 28, 2022 19:15
@pulumi-bot
Copy link
Contributor

pulumi-bot commented Nov 28, 2022 •
edited

Changelog

[uncommitted] (2022-11-28)

Bug Fixes

  • [programgen/nodejs] Add . between ? and [.
    #11477

@iwahbe
Copy link
Member Author

iwahbe commented Nov 28, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 28, 2022

Build succeeded:

@bors bors bot merged commit e2e0941 into master Nov 28, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/8068/ts-dot-optionals branch November 28, 2022 20:06
@justinvp justinvp mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaid-Ajaj Zaid-Ajaj Zaid-Ajaj approved these changes

@aq17 aq17 Awaiting requested review from aq17

Assignees

@iwahbe iwahbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript program codegen: We use the ? operator instead of the ?. operator.
3 participants
@iwahbe @pulumi-bot @Zaid-Ajaj