Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen/go: Remove superfluous newline in doc.go #11492

Merged
merged 1 commit into from Nov 30, 2022
Merged

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Nov 30, 2022

Description

This change fixes the package documentation comment generation that was broken since #10317.

That is, Go requires package documentation comment to be strictly before the package statement without newlines in-between.

Good

// Package good has documentation comment.
package bad

Bad

// Package bad does no have a documentation comment.

package bad

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have run make changelog and committed the changelog/pending/<file> documenting my change
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@pulumi-bot
Copy link
Contributor

Changelog

[uncommitted] (2022-11-30)

Bug Fixes

  • [sdkgen/go] Fixes superfluous newline being added between documentation comment and package statement in doc.go
    #11492

This change fixes the package documentation comment generation that was
broken since #10317.
@Frassle
Copy link
Member Author

Frassle commented Nov 30, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 30, 2022

🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@bors
Copy link
Contributor

bors bot commented Nov 30, 2022

Build succeeded:

@bors bors bot merged commit 7afac76 into master Nov 30, 2022
@bors bors bot deleted the fraser/tieMaster branch November 30, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants