[typescript/sdk-gen] Generate JS doc comments for output-versioned invokes #11511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaid-Ajaj
added
kind/enhancement
Changelog[uncommitted] (2022-12-05)Bug Fixes
|
3 tasks
iwahbe
approved these changes
Dec 2, 2022
Frassle
reviewed
Dec 3, 2022
pkg/codegen/nodejs/gen.go
Outdated
| @@ -1197,7 +1204,7 @@ func (mod *modContext) genFunctionOutputVersion( | |||
|
|
|||
| fmt.Fprintf(w, ` | |||
There was a problem hiding this comment.
The new line here (directly after `) is causing a blank line between the function comments and declaration.
Zaid-Ajaj
force-pushed
the
zaid/better-ts-gen
branch
from
994a9b0
to
10e69f3
Compare
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anytype within apply lambdaThis is part of #11418 but irrelevant to that (big) PR so this will help make the changes smaller and more clear
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change