New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent a deadlock on provider error in py automation api #11595
fix: Prevent a deadlock on provider error in py automation api #11595
Conversation
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
Changelog[uncommitted] (2022-12-09)Bug Fixes
|
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
d77f121
to
57f1096
Compare
PR is now waiting for a maintainer to take action. Note for the maintainer: Commands available:
|
/run-acceptance-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @elthariel! I'll get it merged after the acceptance tests have run.
57f1096
to
4e16d53
Compare
I've noticed in the tests that there was a lint error, so I've updated my PR to fix the issue. I hope it doesn't mess with the acceptance tests |
No worries, I'll re-run |
/run-acceptance-tests |
That's weird. It doesn't seems like it ran the tests again. At least I don't see anything in the list of workflows |
Strange. Not sure why. (We've been tweaking how our CI is setup, so there may be some kinks to work out still). In any case, I ran the linter locally on your branch and it LGTM. |
bors merge |
Build succeeded: |
Description
The rationale behind this change is explained in the linked issue. I haven't worked on the Checklist below, as I'd like to get an eye with more pulumi knownledge on the issue beforehand.
Also, reproducing deadlocks in unit tests is always quite tricky, so I'd rather not do it until I'm sure this is the proper approach
Fixes #11594
Checklist
make changelog
and committed thechangelog/pending/<file>
documenting my change