[sdk/gen] Avoid generating Result types for functions with empty outputs #11596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2022-12-09)Bug Fixes
|
Zaid-Ajaj
added
language/python
language/javascript
language/go
language/dotnet
area/codegen
iwahbe
requested changes
Dec 9, 2022
pkg/codegen/testing/test/testdata/output-funcs/python/pulumi_mypkg/func_with_empty_outputs.py
Outdated
Show resolved
Hide resolved
pkg/codegen/testing/test/testdata/output-funcs/nodejs/funcWithEmptyOutputs.ts
Show resolved
Hide resolved
pkg/codegen/testing/test/testdata/output-funcs/go/mypkg/funcWithEmptyOutputs.go
Show resolved
Hide resolved
iwahbe
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Except for #11596 (comment), my questions have been answered. LGTM!
Zaid-Ajaj
force-pushed
the
zaid/avoid-generating-empty-result-types-for-functions
branch
from
98068fb
to
b0b4add
Compare
iwahbe
reviewed
Dec 9, 2022
| from . import _utilities | ||
|
|
||
| __all__ = [ | ||
| 'func_with_const_input', | ||
| ] | ||
|
|
||
| def func_with_const_input(plain_input: Optional[str] = None, | ||
| opts: Optional[pulumi.InvokeOptions] = None): | ||
| opts: Optional[pulumi.InvokeOptions] = None) -> Awaitable[None]: |
There was a problem hiding this comment.
This doesn't return anything, so I guess None coerces to Awaitable[None].
|
bors merge |
|
Build succeeded: |
bors
bot
deleted the
zaid/avoid-generating-empty-result-types-for-functions
branch
abhinav
added a commit
to pulumi/pulumi-java
that referenced
this pull request
Feb 13, 2023
Void results don't get Result types anymore (pulumi/pulumi#11596)
abhinav
pushed a commit
to pulumi/pulumi-java
that referenced
this pull request
Feb 13, 2023
Bumps [github.com/pulumi/pulumi/pkg/v3](https://github.com/pulumi/pulumi) from 3.49.0 to 3.54.0. To account for changes since 3.49: - Skips two more codegen tests. These were added recently (pulumi/pulumi#11996 and pulumi/pulumi#11893) and the Java SDK does not pass these yet. - Update generated code—a function without a result doesn't get a Result type anymore (pulumi/pulumi#11596).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #11418 where we shouldn't generate result types for function invokes that have no properties.
This is a separate PR to showcase the exact changes required to improve the situation and reduce the diff from #11418
Checklist
make changelogand committed thechangelog/pending/<file>documenting my change